Attention is currently required from: Nicholas Chin, Angel Pons.
View Change
2 comments:
File ch347t_spi.c:
Patch Set #3, Line 119: SPI_NSS_HARD
The vendor drivers set this to 0x0200, which is SPI_NSS_SOFT in the enum. […]
OK, I will change it to SPI_NSS_SOFT, as same as the vendor drivers.
Patch Set #3, Line 420: 0
Rewording what I meant: Mode 1 uses interface 2, so the code currently will not correctly detach the […]
Got it. I will make a change.
To view, visit change 70529. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6da5e308af76693e60308c8165349128e517e09a
Gerrit-Change-Number: 70529
Gerrit-PatchSet: 3
Gerrit-Owner: qianfan <qianfanguijin@163.com>
Gerrit-Reviewer: Angel Pons <angel.pons@9elements.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Attention: Angel Pons <angel.pons@9elements.com>
Gerrit-Comment-Date: Wed, 21 Dec 2022 03:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-MessageType: comment