Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Patch set 4:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #4:
Victor, good news, I rebased the patch again and now it got verified successfully! So it's all good, I will submit it tomorrow.
Sorry for inconvenience.
The difference could be that I rebased on top of main branch.
In comparison, for you locally this patch was a part of the chain, and so it was by default rebased on top of parent commit. And that parent commit was already submitted, so there was no actual difference of rebasing on the same parent again.
To view, visit change 83998. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie733e0c2e35fa4797f5198f2c8334469b65f402c
Gerrit-Change-Number: 83998
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Lim <vlim@gigadevice.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Victor Lim <vlim@gigadevice.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 09:20:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes