Attention is currently required from: Nico Huber, johnsonh@waymo.com, Angel Pons, Andrew Bresticker.
Patch set 4:Code-Review +1
View Change
2 comments:
Commit Message:
Patch Set #4, Line 17: with the same vid/pid/serial number are plugged in, description can still
Looks like this line is just one char over the limit (72 chars).
Also thank you for detailed commit description, very helpful!
File ft2232_spi.c:
Patch Set #4, Line 504: f = ftdi_usb_open_desc(&ftdic, ft2232_vid, ft2232_type, arg2, arg)
Just to double-check, basic case when there is only one device and description param is not provided still works right?
To view, visit change 56164. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib4be23247995710900175f5f16e38db577ef08fa
Gerrit-Change-Number: 56164
Gerrit-PatchSet: 4
Gerrit-Owner: johnsonh@waymo.com
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Andrew Bresticker <abrestic@google.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: johnsonh@waymo.com
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Andrew Bresticker <abrestic@google.com>
Gerrit-Comment-Date: Sat, 24 Jul 2021 02:05:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment