Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer.
View Change
1 comment:
File Makefile:
Patch Set #4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)
Thank you. I know these, but this modification will be inconsistent with meson. […]
I guess you still haven't tested it. Every file that directly or indirectly #includes
the generated header would (with the current version) be recompiled even if nothing
changed.
To view, visit change 49599. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Wang <wxjstz@126.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Idwer Vollering <vidwer@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Shawn C <citypw@hardenedlinux.org>
Gerrit-Attention: Sam McNally <sammc@google.com>
Gerrit-Attention: Xiang Wang <wxjstz@126.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Thu, 22 Apr 2021 11:29:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Xiang Wang <wxjstz@126.com>
Gerrit-MessageType: comment