Attention is currently required from: Angel Pons, Stefan Reinauer.

View Change

5 comments:

• Commit Message:

  • Patch Set #1, Line 9: elivated

    elevated

    Done

  • Patch Set #1, Line 9: privilaged

    privileged

    Done

  • Patch Set #1, Line 13: relative paths however this

    Add some punctuation: […]

    Thanks! Done.

  • Patch Set #1, Line 14: privilaged

    privileged

    Done

• File layout.c:

  • Patch Set #1, Line 199: filename[0] == '\\'

    If this is meant to secure DOS/Windows paths, you'd also have to check for "[a-zA-Z]:", […]

    I would imagine this whole effort is pointless. If you are running flashrom with root privileges reading untrusted binaries via untrusted programmers you already failed. The proper fix is to drop privileges from flashrom upon invocation.

To view, visit change 75194. To unsubscribe, or for help writing mail filters, visit settings.