Attention is currently required from: Hsuan-ting Chen, Jakub Czapiga, Peter Marheine.
3 comments:
Patchset:
Peter, I did review from my side, but I also really interested of what you think. Thank you!
Commit Message:
Patch Set #1, Line 9: Recently Android Bionic LibC got sys/io.h.
With the current code flashrom on Android will work only on super-old builds because glibc-syscalls. […]
The links are non-public, I can't open them from this account. We are public open source project, so the links should be available to everyone.
Telling you so that you know for future :)
To check, you can open link in incognito mode, if it works than all good.
I still appreciate you giving more details! even though I can't see them now.
For this question, actually I checked our documentation, and drumroll, Android is not mentioned anywhere. It is truly undocumented feature, so I think it's fine to update it.
I was thinking to put that "minimum version number" in some doc, but there is no such doc.
File hwaccess_x86_io.c:
Patch Set #1, Line 60: #if defined(__ANDROID__)
For Android you can only build with Android.mk or Android.bp (Soong BluePrint). […]
Thank you for explanation, appreciate it. I had no idea of this.
It seems to be no changes needed for makefile and meson so far.
However, your explanation about building can go to the commit message as a testing info (see my other comment).
To view, visit change 83133. To unsubscribe, or for help writing mail filters, visit settings.