Attention is currently required from: Hsuan-ting Chen, Nikolai Artemiev, Stefan Reinauer.
Patch set 3:Code-Review +1
View Change
2 comments:
Commit Message:
Patch Set #3, Line 15:
I also found datasheet for GD25Q127C
https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20220714/DS-00220-GD25Q127C-Rev2.3.pdf
could you please add to commit message?
I couldn't find GD25Q128C datasheet, but if you have a link to it, would be great to add it too.
Thank you!
File flashchips.c:
Patch Set #3, Line 6846: .name = "GD25Q127C/GD25Q128E",
I think this one should go before previous, alphabetically. It starts with GD25Q127C and the previous one is GD25Q128C
To view, visit change 78348. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3300671b1cf74b3ea0469b9c5a833489ab4914f5
Gerrit-Change-Number: 78348
Gerrit-PatchSet: 3
Gerrit-Owner: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Fri, 03 Nov 2023 07:45:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment