Attention is currently required from: Nico Huber, Anastasia Klimchuk, Nikolai Artemiev.
View Change
1 comment:
File flash.h:
Patch Set #2, Line 148: FEATURE_SR3
Single flag or no flag at all? What information does it carry that wouldn't be […]
It just communicates availability of SR3 since not all chips have it. I mostly followed code that adds SR2 though and can drop this flag if you think it's not actually necessary to guard against accidental use of opcodes that might not be supported.
To view, visit change 60230. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id987c544c02da2b956e6ad2c525265cac8f15be1
Gerrit-Change-Number: 60230
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 17 Jan 2022 15:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-MessageType: comment