Attention is currently required from: Evan Benn.
Patch set 1:Code-Review +1
View Change
2 comments:
File writeprotect.c:
Patch Set #1, Line 166: return FLASHROM_WP_ERR_READ_FAILED;
This does slightly change the behaviour where before an early failure would be a VERIFY_FAILED but n […]
The error code change seems fine.
Patch Set #1, Line 168: wp_verify
nit: change to `%s:` and add `__func__` as a format arg
ditto in debug call below
To view, visit change 67720. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5fcaf767570418f90ae44826a1135d9b49653033
Gerrit-Change-Number: 67720
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn@google.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Evan Benn <evanbenn@google.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 00:56:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Evan Benn <evanbenn@google.com>
Gerrit-MessageType: comment