Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.

View Change

2 comments:

• File meson.build:

  • Patch Set #2, Line 98: # 'deps' : list[dep], # fallback: []

    I'll have a deeper look at it. But I don't think so. […]

    It's possible but quite complicated to put an optional external dependency together with an source file and would make the meson code less readable.
    I would prefer to list all source files which are needed for a programmer into the `srcs` attribute.
    For the dependencies on host system support like serial, spi driver, i2c driver we could spit the support into the platform abstraction and the programmer shared code. Build the platform support as part of the dependency and the shared code as part of the programmer.

  • Patch Set #2, Line 464: if host_machine.system() in systems_serial_support

    I haven't looked deeply into the serial code how to build it the bust way. […]

    For now the serial support is build as part of the programmer. I suggest to split the serial support into a platform abstraction, which is build as dependency, and code which is shared between the programmer.

To view, visit change 63724. To unsubscribe, or for help writing mail filters, visit settings.