Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.
6 comments:
File include/programmer.h:
Patch Set #3, Line 131: pcidev_phantom_spi
Can we generalise the names, so that this can be used for any device? Something like `pcidev_phantom_dev` here would work for me, and functions would be renamed accordingly.
no space after unary *
no space after unary *
struct pcidev_phantom_spi * pcidev_phantom_new_spidev(struct pci_dev *const dev, const int slot, const int func);
struct pci_dev * pcidev_phantom_spidev(struct pcidev_phantom_spi *const ph_spidev);
void pcidev_phantom_release(struct pcidev_phantom_spi *const ph_spidev);
There's no need to declare parameters as const in the function declaration, the caller doesn't care.
Note: In something like `const char *const str`, only the second `const` is unnecessary. I mentally read `const char *str` as "`str` is a pointer to `const char`".
File pcidev.c:
no space after unary *
no space after unary *
To view, visit change 62951. To unsubscribe, or for help writing mail filters, visit settings.