View Change

2 comments:

• File sb600spi.c:

  • Patch Set #1, Line 451: (amd_gen < CHIPSET_BOLTON))

    Looking at the code below again, it seems that spireadmode does not have an effect for chipsets < Bo […]

    Done

  • Patch Set #1, Line 509:

    if (spispeed_idx >= 0 && set_speed(dev, spispeed_idx) != 0) {
    		return 1;
    	}
    	return 0;
    

    Well, the previous code defaulted to 3, so it never barfed. Still, I would consider it an error. […]

    set_speed only writes to the register for setting the speed. Skipping this is intentional. The assumption is that the firmware should have already configured the optimal spi speed, so just default to leaving it unchanged for >= BOLTON. I added a warning for both spireadmode and spispeed when they are left unset.

To view, visit change 38833. To unsubscribe, or for help writing mail filters, visit settings.