Patch set 4:Code-Review +2

View Change

4 comments:

• Commit Message:

  • Patch Set #4, Line 7: Simplifying the initialisation flow for it85spi

    `it85spi.c: Inline it85xx_spi_common_init()`

  • Patch Set #4, Line 9:

    1) Inlining it85xx_spi_common_init since it's only used once in
    it85xx_spi_init, after inlining ret value is not needed.
    

    no need for the points.

    ```
    Inline it85xx_spi_common_init() to single call site of `it85xx_spi_init() as the construction is a single phase one. This allows for less cyclomatic complexity by validating early and initialisation at the eulogy of the one entry-point to the driver.
    ```

• File it85spi.c:

  • Patch Set #1, Line 362: */

    Not sure what do you mean here: do you mean this FIXME comment should be below /* Set this as SPI co […]

    Ack

• File it85spi.c:

  • Patch Set #2, Line 360: free(data);

    It maybe a bit more clear now for you that this just papers over the issue that register_shutdown() […]

    Ack

To view, visit change 48196. To unsubscribe, or for help writing mail filters, visit settings.