Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.

View Change

2 comments:

• File ichspi.c:

  • Patch Set #2, Line 1349: static int ich_hwseq_read_status(const struct flashctx *flash, enum flash_reg reg_, uint8_t *value)

    I think both functions should fail if reg_ is not SR1.

    Done

  • Patch Set #2, Line 1352: int len = 1;

    I'd make len a constant in both functions. […]

    Done

To view, visit change 64540. To unsubscribe, or for help writing mail filters, visit settings.