Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Evan Benn.
View Change
1 comment:
Commit Message:
Patch Set #5, Line 7: tests: Convert selfcheck to unit tests
Yes that's fine thanks, we intend to add this hopefully equivalent unit test and then disable runtim […]
Maybe instead of "Convert" say "Supplement" just to avoid confusion.
To view, visit change 69620. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a
Gerrit-Change-Number: 69620
Gerrit-PatchSet: 5
Gerrit-Owner: Evan Benn <evanbenn@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Evan Benn <evanbenn@google.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 04:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Evan Benn <evanbenn@google.com>
Gerrit-MessageType: comment