Welcome!

Overall, looks good, but with some minor nits about formatting.

Patch set 1:Code-Review +1

View Change

7 comments:

• Commit Message:

  • Patch Set #1, Line 7: flashrom: Added Support for BoyaMicro BY25Q128AS

    A few nits about the commit summary:

    • The `prefix` often refers to the touched files. Here, `flashchips` would be good (both flashchips.c and flashchips.h are touched).
    • Commit summaries are written in imperative tense: `Add support for ...`.
    • `Support` shouldn't be capitalized.
    • The vendor's name seems to be `Boya Microelectronics`.

    Instead, I would use:

     flashchips: Add support for Boya Microelectronics BY25Q128AS

    Note that commit summaries never end with a period.

  • Patch Set #1, Line 9: Tested on Buspirate

    missing period `.` at the end.

• File flashchips.h:

  • Patch Set #1, Line 211:

    These spaces should be a tab (tabs are 8 characters wide in flashrom)

  • Patch Set #1, Line 212:

    Same here, spaces

• File flashchips.c:

  • Patch Set #1, Line 3445:

    more spaces

  • Patch Set #1, Line 3446: Boya

    nit: Boya Microelectronics

  • Patch Set #1, Line 3449: BOYA_ID

    the `BOYA_ID` macro name is fine, no need to change it.

To view, visit change 44308. To unsubscribe, or for help writing mail filters, visit settings.