Attention is currently required from: Nico Huber, Thomas Heijligen.

2 comments:

Patchset:
- Patch Set #39:
  Can you provide a description what each test is doing?
  Wouldn't that just duplicate test name, code and comments in tests? Maybe provide an example of a description you'd like to see.
File tests/chip_wp.c:
- Patch Set #39, Line 63: static const struct flashchip chip_W25Q128_V = {
  Why copying the chip?
  It's copied in `chip.c`, so I did the same. I think the rational is that tests don't operate on real chips, so they should use their own definition with real chip as a reference.

To view, visit change 59075. To unsubscribe, or for help writing mail filters, visit settings.