Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
programmer.h,c: Drop dead noop_chip_writeb() fn

Drop dead code.

BUG=none
BRANCH=none
TEST=`git grep noop_chip_writeb`

Change-Id: I160406df903b3b0a49a5ff3ec78a030e10fa60a0
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/47894
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
---
M programmer.c
M programmer.h
2 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/programmer.c b/programmer.c
index f4b4384..5c841ef 100644
--- a/programmer.c
+++ b/programmer.c
@@ -35,11 +35,6 @@
{
}

-/* No-op chip_writeb() for parallel style drivers not supporting writes */
-void noop_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr)
-{
-}
-
/* Little-endian fallback for drivers not supporting 16 bit accesses */
void fallback_chip_writew(const struct flashctx *flash, uint16_t val,
chipaddr addr)
diff --git a/programmer.h b/programmer.h
index 1bd0d37..ed30d89 100644
--- a/programmer.h
+++ b/programmer.h
@@ -730,7 +730,6 @@
int noop_shutdown(void);
void *fallback_map(const char *descr, uintptr_t phys_addr, size_t len);
void fallback_unmap(void *virt_addr, size_t len);
-void noop_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr);
void fallback_chip_writew(const struct flashctx *flash, uint16_t val, chipaddr addr);
void fallback_chip_writel(const struct flashctx *flash, uint32_t val, chipaddr addr);
void fallback_chip_writen(const struct flashctx *flash, const uint8_t *buf, chipaddr addr, size_t len);

To view, visit change 47894. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I160406df903b3b0a49a5ff3ec78a030e10fa60a0
Gerrit-Change-Number: 47894
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged