Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Aarya.
Patch set 83:Code-Review +1
15 comments:
File erasure_layout.h:
Patch Set #83, Line 37: int erase_write(struct flashctx *const flashctx, chipoff_t region_start, chipoff_t region_end, uint8_t* curcontents, uint8_t* newcontents, struct erase_layout *erase_layout, bool *all_skipped);
We have a hard limit of 112 chars per line, this one is too long
See dev guidelines: https://www.flashrom.org/Development_Guidelines#Coding_style
File erasure_layout.c:
Patch Set #83, Line 203: ll->selected = need_erase(curcontents + start_addr, newcontents + start_addr, erase_len, flashctx->chip->gran, erased_value);
This line also exceeds 112 chars.
In general, I see some of the lines are too long, could you please check for all the code in this file?
Patch Set #83, Line 245: uint8_t* old_start_buf = (uint8_t*)malloc(old_start - region_start);
new line before
when you are going through code to check for line limit 112chars, try to add a space between `//` and the comment text
Patch Set #83, Line 268: //select erase functions
new line before
Patch Set #83, Line 277: for (i = 0; i < erasefn_count; i++) {
new line before
comment is misaligned, too many tabs ?
Patch Set #83, Line 325: //adjust curcontents
new line before
Patch Set #83, Line 336: *all_skipped = false;
new line before
Patch Set #83, Line 339: //write
new line before
trailing space (Gerrit shows it bright pink :))
Patch Set #83, Line 352: //adjust curcontents
new line before
Patch Set #83, Line 355: *all_skipped = false;
new line before
Patch Set #83, Line 366: free(old_start_buf);
new line before
Patch Set #83, Line 368: msg_cinfo("Erase/write done from %x to %x\n", region_start, region_end);
new line before
To view, visit change 65844. To unsubscribe, or for help writing mail filters, visit settings.