Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Kane Chen.
View Change
1 comment:
File meson_options.txt:
Patch Set #3, Line 9: option('use_libpci_ecam', type : 'boolean', value : false)
It looks like this is only used for 100-series PCHs which presumably always support ECAM, so is this option needed?
It seems like if we can assume ECAM is always available on the relevant systems and it's less prone to bugs caused by libpci interacting poorly with OS-level drivers accessing the same hardware, then we should use ECAM as long as it's supported by the version of libpci in use and don't need this option.
To view, visit change 83896. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I4549f87c8b01da0a1d3d8ce0b3b75c1f5fa2cbab
Gerrit-Change-Number: 83896
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen <kane.chen@intel.com>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-CC: Kane Chen <kane.chen@intel.corp-partner.google.com>
Gerrit-Attention: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Kane Chen <kane.chen@intel.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 03:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No