Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Edward O'Callaghan.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    > Don't call map_flash for X86 you mean? or get rid of the call to map_flash here https://review. […]

    To me, it looks like we already went too deep, all the way to physmap_common, and only then realised that mapping is not needed so returning an error. Is it possible to analyse the situation earlier? Maybe here (if it is programmer-specific) https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/flashrom.c#201

    Even commit message seems to support this idea, it says "Return early from map_flash <...>" ;)

To view, visit change 56721. To unsubscribe, or for help writing mail filters, visit settings.