Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42796 ) Change subject: ft2232_spi.c: align with Chrome OS flashrom ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/flashrom/+/42796/1/ft2232_spi.c File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/42796/1/ft2232_spi.c@420 PS1, Line 420: DIS_DIV_5;
It looks like they already depend on libftdi1, which has DIS_DIV_5 AFAICT. OK, SGTM. Please give some time for the community to review as well.
-- To view, visit https://review.coreboot.org/c/flashrom/+/42796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I24c20e9b5d7e661d0180699bbd0d1447f6bf816f Gerrit-Change-Number: 42796 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 26 Jun 2020 07:23:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com> Gerrit-MessageType: comment