Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• Commit Message:

  • Patch Set #12, Line 12: .

    Also state the previous mode here that is currently assumed.

    Done

• File bitbang_spi.c:

  • Patch Set #12, Line 208:

    
    	if (parse_spi_mode(&cpol, &cpha))
    		return ERROR_FLASHROM_BUG;
    

    Hmm, the only thing is this could be a little too harsh for this patch in that, could we just assume […]

    If the parameter mode is not set, parse_spi_mode returns 0. cpol/cpha will default to 0 and use spi's mode0. Only when the user specifies the mode parameter and the value of mode is not 0-3 will an error occur

To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.