Attention is currently required from: Anastasia Klimchuk.

View Change

22 comments:

• File ft2232_spi.c:

  • Patch Set #1, Line 108: struct ftdi_context *ftdic_context;

    instead of making this a pointer how about just `struct ftdi_context ftdic_context;`

  • Patch Set #1, Line 168: struct ftdi_context *ftdic = spi_data->ftdic_context;

    remove

  • Patch Set #1, Line 186: free(ftdic);

    remove

  • Patch Set #1, Line 198: s

    &

  • Patch Set #1, Line 322: struct ftdi_context *ftdic;

    `struct ftdi_context ftdic;`

  • Patch Set #1, Line 534:

    	ftdic = calloc(1, sizeof(struct ftdi_context));
    	if (!ftdic) {
    		msg_perr("Unable to allocate memory for ftdi_context.\n");
    		return SPI_GENERIC_ERROR;
    	}
    

    remove

  • Patch Set #1, Line 540: ftdic

    &

  • Patch Set #1, Line 542: free(ftdic);

    remove

  • Patch Set #1, Line 546: f

    &

  • Patch Set #1, Line 547: f

    &

  • Patch Set #1, Line 551: f

    &

  • Patch Set #1, Line 556: f

    &

  • Patch Set #1, Line 557: free(ftdic);

    remove

  • Patch Set #1, Line 561: f

    ftdic.type

  • Patch Set #1, Line 562: ftdic->type

    ftdic.type

  • Patch Set #1, Line 566: f

    &

  • Patch Set #1, Line 567: f

    &

  • Patch Set #1, Line 618: f

    &

  • Patch Set #1, Line 626: spi_data->ftdic_context = ftdic;

    memcpy() the local stack allocated one into the field.

  • Patch Set #1, Line 639: f

    &

  • Patch Set #1, Line 641: f

    &

  • Patch Set #1, Line 644: free(ftdic);

    remove

To view, visit change 52256. To unsubscribe, or for help writing mail filters, visit settings.