Attention is currently required from: Alexandru Stan, Anastasia Klimchuk, Stefan Reinauer.

Patch set 2:Code-Review +1

View Change

1 comment:

• File flashchips.c:

  • Patch Set #2, Line 20269:

    		.printlock	= SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD,
    		.unlock		= SPI_DISABLE_BLOCKPROTECT,
    
    

    Actually, from the datasheet this is fine, leave it. […]

    It'd be nice to add full WP support, reusing the values from `W25Q512NW-IM` should work here.

    I.e.

    ```
                    .feature_bits   = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA  | FEATURE_WRSR2
                                      | FEATURE_WRSR3,
                    .reg_bits       =
                    {
                            .srp    = {STATUS1, 7, RW},
                            .srl    = {STATUS2, 0, RW},
                            .bp     = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}},
                            .tb     = {STATUS1, 6, RW},
                            .cmp    = {STATUS2, 6, RW},
                            .wps    = {STATUS3, 2, RW},
                    },
                    .decode_range   = DECODE_RANGE_SPI25,
    ```

    
    Also drop unlock/printlock.

    And assuming WP commands like `flashrom --wp-status; flashrom --wp-list; flashrom --wp-enable; flashrom --wp-disable` work properly, also set `TEST_OK_PREWB`.

To view, visit change 84752. To unsubscribe, or for help writing mail filters, visit settings.