Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
3 comments:
Patchset:
Victor thank you, the patch looks good!
I only have comments about commit message. You can modify the commit message in Gerrit, there is an Edit button below commit message box.
Also just to check, you have tested the models you are adding, is that right?
Do you have the link to datasheet for GD25LR128E ? Thank you!
Commit Message:
Patch Set #1, Line 7: GD25LQ128E/GD25LB128E/GD25LR128E/GD25LQ128D/GD25LQ128C
You can replace this list with GD25LB128E/GD25LR128E , because you add two models, and the others were here before. So commit title will be
flashchips: Add support for chip model GD25LB128E/GD25LR128E
Adding GD25LQ128E/GD25LB128E/GD25LR128E/GD25LQ128D/GD25LQ128C to flashchip.c
These part # sharing the same ID, form, fit, function, produced with different process node: 1.8V 128Mbit
You need to wrap the commit message to be 72 chars max width.
(links to datasheets are exception, leave them long)
Keep the same text, but break the lines so that each line no longer than 72 chars.
To view, visit change 83012. To unsubscribe, or for help writing mail filters, visit settings.