Anastasia Klimchuk submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
tests: Rename init_shutdown.c into lifecycle.c

Lifecycle tests are getting an upgrade later in this chain, which
means lifecycle becomes more than just init and shutdown. Rename
into lifecycle.c to reflect the upgrade.

BUG=b:181803212
TEST=ninja test

Change-Id: I8d734c43cc15c7ec1055d3fb5bdcdca8c90d0987
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/59739
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
---
R tests/lifecycle.c
M tests/meson.build
M tests/tests.c
M tests/tests.h
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/init_shutdown.c b/tests/lifecycle.c
similarity index 100%
rename from tests/init_shutdown.c
rename to tests/lifecycle.c
diff --git a/tests/meson.build b/tests/meson.build
index 2f0fc67..610d1c6 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -20,7 +20,7 @@
'helpers.c',
'flashrom.c',
'spi25.c',
- 'init_shutdown.c',
+ 'lifecycle.c',
'layout.c',
'chip.c',
]
diff --git a/tests/tests.c b/tests/tests.c
index 1dda467..74a4f57 100644
--- a/tests/tests.c
+++ b/tests/tests.c
@@ -362,7 +362,7 @@
};
ret |= cmocka_run_group_tests_name("spi25.c tests", spi25_tests, NULL, NULL);

- const struct CMUnitTest init_shutdown_tests[] = {
+ const struct CMUnitTest lifecycle_tests[] = {
cmocka_unit_test(dummy_init_and_shutdown_test_success),
cmocka_unit_test(nicrealtek_init_and_shutdown_test_success),
cmocka_unit_test(raiden_debug_init_and_shutdown_test_success),
@@ -371,7 +371,7 @@
cmocka_unit_test(linux_spi_init_and_shutdown_test_success),
cmocka_unit_test(realtek_mst_init_and_shutdown_test_success),
};
- ret |= cmocka_run_group_tests_name("init_shutdown.c tests", init_shutdown_tests, NULL, NULL);
+ ret |= cmocka_run_group_tests_name("lifecycle.c tests", lifecycle_tests, NULL, NULL);

const struct CMUnitTest layout_tests[] = {
cmocka_unit_test(included_regions_dont_overlap_test_success),
diff --git a/tests/tests.h b/tests/tests.h
index f1b4e9b..5480beb 100644
--- a/tests/tests.h
+++ b/tests/tests.h
@@ -40,7 +40,7 @@
void probe_spi_at25f_test_success(void **state);
void probe_spi_st95_test_success(void **state); /* spi95.c */

-/* init_shutdown.c */
+/* lifecycle.c */
void dummy_init_and_shutdown_test_success(void **state);
void nicrealtek_init_and_shutdown_test_success(void **state);
void raiden_debug_init_and_shutdown_test_success(void **state);

To view, visit change 59739. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8d734c43cc15c7ec1055d3fb5bdcdca8c90d0987
Gerrit-Change-Number: 59739
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged