View Change

5 comments:

• File cbtable.c:

  • Patch Set #5, Line 43: image + size - 0x10

    I think this parses as (image + size) - 0x10, right?

  • Patch Set #5, Line 51: image + size - 0x80

    Ditto

  • Patch Set #5, Line 69: image + size - mb_part_offset

    Ditto

  • Patch Set #5, Line 70: image + size - mb_vendor_offset

    Ditto

• File fmap.c:

  • Patch Set #5, Line 99: (len - sizeof(struct fmap))

    Not sure anymore why I placed the parentheses. It looks like it would be […]

    If len < sizeof(struct fmap), we could just do an early return -2, so there's no problem of overflow then.

To view, visit change 30409. To unsubscribe, or for help writing mail filters, visit settings.