Attention is currently required from: Felix Singer, Edward O'Callaghan, Nikolai Artemiev.
View Change
2 comments:
Commit Message:
Patch Set #4, Line 7: ichspi: Remove unneeded line breaks, add useful ones
There are also some other changes, e.g. added tabs.
Oh yes right, I added "tabs" into commit description.
Patch Set #4, Line 13: 2) probe and read on Panther Point (7 series PCH)
Not this patch, actually. […]
Oh yes sorry! I messed up commit messages by doing copy-pasting... I went through the chain now and hopefully corrected them.
For this one, I tested that the binary is still the same and put this as p.2.
Also as a summary: looks like only the first patch needs to be tested on ICH7, the rest of chain doesn't need to be, is this correct?
To view, visit change 60272. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ca2902b7caaa95418b828b068c661afafdcd171
Gerrit-Change-Number: 60272
Gerrit-PatchSet: 7
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 10 Jan 2022 00:56:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment