Attention is currently required from: Angel Pons, Evan Benn.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 9: string
nit: capitalize "String"?
See above, 'String' vs 'string' have very specific meanings. My advise here is to say `str` to avoid the ambiguity of a lower case 'string'.
To view, visit change 69064. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I69531bec5436a60430eae975eeab02c8835962bf
Gerrit-Change-Number: 69064
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Benn <evanbenn@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Evan Benn <evanbenn@google.com>
Gerrit-Comment-Date: Tue, 01 Nov 2022 22:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment