View Change

1 comment:

• File cli_classic.c:

  • Patch Set #6, Line 718:

    		start = strtoul(argv[optind], &endptr, 0);
    		if (errno == ERANGE || errno == EINVAL || *endptr != '\0') {
    			msg_gerr("Error: value \"%s\" invalid\n", argv[optind]);
    			ret = 1;
    			goto out_shutdown;
    		}
    
    		len = strtoul(argv[optind + 1], &endptr, 0);
    		if (errno == ERANGE || errno == EINVAL || *endptr != '\0') {
    			msg_gerr("Error: value \"%s\" invalid\n", argv[optind + 1]);
    

    Yikes... Yeah, this is pretty suspicious. […]

    • Beyond the technical I would just like to state my position while we are upstreaming this stuff from the ChromiumOS fork:

    I would be willing - in the interest of community spirt, correct and quality engineering - to do whatever needs to be done correctly in upstream and deal with ChromiumOS's mitigration path locally downstream. It isn't fair on the community to bring bargage from Google into upstream and so I think we should shoulder the responsibility of that locally.

    • As for the technical:

    I would then be inclinded to follow Nikolai second cleaner solution and agree with Hendricks to make the bold move to a new preidctable syntax that is determistically parsable.

To view, visit change 40325. To unsubscribe, or for help writing mail filters, visit settings.