Attention is currently required from: Nico Huber, Sergii Dmytruk.

Patch set 1:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 7: writeprotect

    nit: `writeprotect.c:`

• File writeprotect.c:

  • Patch Set #1, Line 158: old

    `actual`

  • Patch Set #1, Line 159: new

    `expected`

  • Patch Set #1, Line 160: old == new

    You may reuse the result from line159 one line163,

    ```
    if (actual == expected)
    	continue;

    value = (value & ~write_masks[reg]) | expected;

    if (wp_write_register(flash, reg, value))
    	return FLASHROM_WP_ERR_WRITE_FAILED;
    }
    ```

To view, visit change 66754. To unsubscribe, or for help writing mail filters, visit settings.