Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43501 ) Change subject: ichspi.c: Make pprinters parameterics on ich_generation ...................................................................... Patch Set 1: Code-Review+2 (3 comments) https://review.coreboot.org/c/flashrom/+/43501/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/43501/1//COMMIT_MSG@7 PS1, Line 7: parameterics parametric https://review.coreboot.org/c/flashrom/+/43501/1//COMMIT_MSG@9 PS1, Line 9: depending on taking https://review.coreboot.org/c/flashrom/+/43501/1//COMMIT_MSG@10 PS1, Line 10: ich_generation ich_generation value -- To view, visit https://review.coreboot.org/c/flashrom/+/43501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d4fb012c6b9b843ac30c1fe2ea6fe754c545a43 Gerrit-Change-Number: 43501 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 16 Jul 2020 10:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment