Nico Huber posted comments on this change.

View Change

Patch set 1:

Um, actually I omitted the consts on purpose. They are not part of the
signature. Since everything is passed by value in C, it makes no dif-
ference for the caller if we are going to change our copy of the argu-
ment or not.

I don't have strong feelings about it though. Just the commit message
should change if you want to change it nevertheless.

To view, visit change 20812. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I5840b95f9f9254e20d99bd01d0b1009c4b2252c4
Gerrit-Change-Number: 20812
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Comment-Date: Fri, 28 Jul 2017 21:48:57 +0000
Gerrit-HasComments: No