Attention is currently required from: Felix Singer, Martin Roth, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
View Change
2 comments:
File flashrom.8.tmpl:
Patch Set #3, Line 1145: <ec|ap>
What we usually do with programmer arguments is to mention a
placeholder and describe valid values in the text, highlighted
as follows:
.B " flashrom \-p raiden_debug_spi:target=chip"
.sp
syntax, where
.B chip
is either
.B ap
or
.B ec
Patch Set #3, Line 1166: false
Was this tested? I can't find "false" in the code.
To view, visit change 62768. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4
Gerrit-Change-Number: 62768
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 11 Apr 2022 11:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment