Attention is currently required from: Robert Zieba, Paul Menzel, Jon Murphy, Edward O'Callaghan, Karthik Ramasubramanian.
View Change
2 comments:
Commit Message:
Patch Set #1, Line 8:
Flashrom has been using legacy spi100 bit mappings when programming the
opcode and triggering the command. These legacy bit mappings are
deprecated in upcoming generation of AMD SoCs.
Added more details relevant to this CL. […]
spi_ctrlr_xfer in soc/amd/common/block/spi/fch_spi_ctrl.c in coreboot might clarify a bit how this spi100 engine is used
Patch Set #1, Line 11:
Stop using the legacy
spi100 registers and use the correct ones.
Done
give me a few hours to check with the docs that this won't break things on older platforms before landing this patch
To view, visit change 63422. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If42130757331f4294b5a42c848557d3287f24fc3
Gerrit-Change-Number: 63422
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jon Murphy <jpmurphy@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Robert Zieba <robertzieba@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Robert Zieba <robertzieba@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Jon Murphy <jpmurphy@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Comment-Date: Thu, 07 Apr 2022 18:42:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba <robertzieba@google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment