Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk, Peter Marheine.
View Change
1 comment:
File layout.c:
Patch Set #5, Line 397: malloc
It seems reasonable to be defensive here, to more predictably catch use of uninitialized entries.
I am not used to such errors, so I need much more details about
the expectations. How does it look like when you catch an unwanted
0-initialization? How is it better compared to some random value?
What is the expected effect on programming habits? For instance,
I'd expect people to be lulled in false confidence that things
are usually 0-initialized (instead of learning C semantics properly).
That's just an example; I'd need something that outweighs such
concerns, then I'd be happy to support this pattern.
To view, visit change 33543. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2ae7246493ff592e631cce924777925c7825e398
Gerrit-Change-Number: 33543
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Mon, 21 Jun 2021 10:04:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment