Attention is currently required from: Subrata Banik, Angel Pons.
View Change
1 comment:
File board_enable.c:
Patch Set #4, Line 1097: pcidev_getdev1
This was discussed before, see https://review.coreboot.org/c/flashrom/+/59276/3..4/board_enable. […]
Thanks Subrata, I had a similar though to use the signature `struct pci_dev *pcidev_getdevfn(struct pci_dev *dev, const int func)` that's a good name! Thank you for the detailed suggestion.
While there is only one call site but I think this is a good compromise to get this patch moving again.
To view, visit change 59276. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id9ce055d5e5d347520ec5002b8c6548e60eaa0a7
Gerrit-Change-Number: 59276
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 28 Feb 2022 23:29:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment