Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk, Sergii Dmytruk.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #34, Line 169: assert

    Sorry, I haven't read your follow up before this comment. […]

    So this is a pure function with domain of { STATUS1, STATUS2, STATUS3 }, which is mapped to { SPI_SR_WIP, 0, 0 } respectively. I'd remove the function unless it's necessary to call it with non-constant arguments (i.e. if the value of the `status_reg` parameter isn't always known at compile-time).

To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.