This seems fine, however I wonder if it will be better to set the chunksize in ft2232_spi_send_command() where we have flash context and can tell if we're dealing with a large chip with a 4-byte address, since that will require adding another byte to the chunksize?

Patch set 4:Code-Review +1

View Change

To view, visit change 39632. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iac067a23025e9df053ab9cd4e82a98de70046c18
Gerrit-Change-Number: 39632
Gerrit-PatchSet: 4
Gerrit-Owner: el-coder-sb
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 22 Mar 2020 17:55:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment