Attention is currently required from: Anastasia Klimchuk, Matti Finder.
View Change
1 comment:
File rpmc.c:
Patch Set #4, Line 117: usleep(flash->chip->rpmc_ctx.polling_long_delay_write_counter_us)
Peter, I wanted to check, is this the right way to sleep? Are we supposed to be using `programmer_de […]
`programmer_delay` seems like the right choice here, since we have a flashctx.
To view, visit change 84934. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38
Gerrit-Change-Number: 84934
Gerrit-PatchSet: 5
Gerrit-Owner: Matti Finder <matti.finder@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Matti Finder <matti.finder@gmail.com>
Gerrit-Comment-Date: Tue, 05 Nov 2024 03:37:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>