Nico Huber merged this change.

View Change

Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved
internal: Fix #if guards for big-endian mips

Newer GCC still warns on big-endian mips, cf. 60210de
(internal: Fix warnings about unused constants).

Change-Id: Id0508c5241a7bd61b8d92d631cdf42ef7829a8a9
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/23003
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
---
M internal.c
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/internal.c b/internal.c
index 276e14b..cb02753 100644
--- a/internal.c
+++ b/internal.c
@@ -131,7 +131,7 @@
int is_laptop = 0;
int laptop_ok = 0;

-#if IS_X86 || IS_MIPS
+#if (IS_X86 || IS_MIPS) && defined(__FLASHROM_LITTLE_ENDIAN__)
static void internal_chip_writeb(const struct flashctx *flash, uint8_t val,
chipaddr addr);
static void internal_chip_writew(const struct flashctx *flash, uint16_t val,
@@ -360,7 +360,7 @@
}
#endif

-#if IS_X86 || IS_MIPS
+#if (IS_X86 || IS_MIPS) && defined(__FLASHROM_LITTLE_ENDIAN__)
static void internal_chip_writeb(const struct flashctx *flash, uint8_t val,
chipaddr addr)
{

To view, visit change 23003. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0508c5241a7bd61b8d92d631cdf42ef7829a8a9
Gerrit-Change-Number: 23003
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>