Attention is currently required from: Anastasia Klimchuk.

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #2, Line 133: " --use-first-chip in cases where multiple chips are detected, use the first one found\n"

    This is potentially dangerous option: because same IDs can be not only between the chips in the same […]

    here's my problem: if you're flashing internally, you likely have no idea what chip is actually on the board. So when presented with 2 or more options and told to choose, how are you supposed to make that determination?
    With external flashing you can easily inspect the chip, so not a problem. But the vast majority of my users (ChromeOS devices owners) have no idea where the flash chip is on their device, how to access it, etc and I don't have a good way to help them resolve the question.

    I don't know that we need to make the name scary. And if anything, I'd argue those overrides you used as examples are poorly named since they don't make it obvious what function they serve.

To view, visit change 85160. To unsubscribe, or for help writing mail filters, visit settings.