Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Martin Roth.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I wasn't aware of the amd_spi100.c plan when I did this though.

    The plan @flashrom-stable is to have one driver per interface (mostly to
    restart something for fam17h+ that is fully tested; after important fixes
    @flashrom[1] were stalled indefinitely waiting for tests on Chromebooks,
    feedback on Edward's ticket @AMD, and finally doubts on the overall state
    of the code). Cleanup of sb600spi.c is in progress but would need testing[2].
    Naming a driver after the first chip that introduced the interface is quite
    common, so we left the name.

    Feel free to downstream amd_spi100 and/or to test the cleanup patches if
    you have suitable hardware. The first needs testing with amd_spi100 for older
    SoCs, Kabini/Stoney maybe. The latter could use some test on even older
    hardware, to confirm that the original sb600spi path still works.

    [1] CB:58776, https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/SSTV3VORFX55R4LBUOJUU6WL6OQPFUFU/
    [2] CB:72584, CB:72585

To view, visit change 74952. To unsubscribe, or for help writing mail filters, visit settings.