Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
1 comment:
File tests/meson.build:
p_data += {
'testsrc' : p_data.get('testsrc', []),
}
srcs += p_data.get('testsrc')
I came up with one question, wanted to clarify. At the moment we need all test files to be included in the build, regardless of whether programmer is enabled or not. Does this work like that?
Yes, all test files need to be included currently. Just the implementation of the methods differs depending on the programmer configuration (actual test code vs skip test dummy code).
> why https://review.coreboot.org/c/flashrom/+/67664/5 (PS5, *not* the recent patchset) passed the jenkins? I would assume it should not, because line 43 in PS5 skips the wrong test?
>
> I checked test_build script, and I see it is running tests in the loop, each time one programmer enabled. In my mind, the tests where ch341a_spi is disabled should fail to build (to link) on 67664/5 but that didn't happen? I am confused :) and please tell me if I am writing into a wrong place! This place seems somewhat relevant.
You are right. I was confused first too, buuuut actually Jenkins did its job as expected :)
We need to look more closely: Patchset 5 was pushed on 23th September. I checked it out locally and looked at test_build.sh. At that time we only iterated over all programmers using the Make build system. For the Meson build system we just used the default configuration, since probably the Meson refactoring patch wasn't merged yet.
meson $builddir -Dtests=enabled
ninja -C $builddir
ninja -C $builddir test
So we didn't iterate over all programmers yet and built them individually, which means CH341A was part of the default programmer selection and so the actual tests were compiled in and executed by Jenkins. That's why the issue was hidden :)
Meanwhile we also iterate over all programmers using the Meson build system, but the programmer list in test_build.sh needs to be refactored as well. See CB:68068.
To view, visit change 68162. To unsubscribe, or for help writing mail filters, visit settings.