Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.

Alexander Goncharov uploaded patch set #7 to this change.

View Change

cli_classic: move validation of incompatible options to one place

Avoid repeating the same messages.

TOPIC=split_main_func
TEST=the following scenarios failed as expected

./flashrom -p dummy:emulate=W25Q128FV -v "ff.bin" -n
./flashrom -p dummy:emulate=W25Q128FV -l "tmp.layout" --ifd
./flashrom -p dummy:emulate=W25Q128FV -l "tmp.layout" --fmap
./flashrom -p dummy:emulate=W25Q128FV -l "tmp.layout" --fmap-file "fmap.bin"
./flashrom -p dummy:emulate=W25Q128FV --wp-enable --wp-disable
./flashrom -p dummy:emulate=W25Q128FV \
-l "tmp.layout" \
--wp-enable \
--wp-range=0x00000000,0x01000000 \
--wp-region "boot"

Change-Id: If6d7579847cc8ae13b54ef7bd50072a9402f835f
Signed-off-by: Alexander Goncharov <chat@joursoir.net>
---
M cli_classic.c
1 file changed, 38 insertions(+), 33 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/66532/7

To view, visit change 66532. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If6d7579847cc8ae13b54ef7bd50072a9402f835f
Gerrit-Change-Number: 66532
Gerrit-PatchSet: 7
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: newpatchset