Attention is currently required from: Aarya, Peter Marheine.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Running this on head, erase blocks are more granular than expected, specifically: […]

    I know why sometimes smaller adjacent blocks are not merged into a larger block. Because they belong to the different blocks of size+1.

    That's the second case here specifically

     1031 Eraser called with blockaddr=0x2, blocklen=0x2
     1033 Eraser called with blockaddr=0x4, blocklen=0x2

    size+1 is blocklen==4 and blockaddr 0x2 vs 0x4 belong to the different blocks of size 4

    To merge them, we would need to do a second pass after all blocks are selected, and potentially merge

To view, visit change 82723. To unsubscribe, or for help writing mail filters, visit settings.