Attention is currently required from: Anastasia Klimchuk, Richard Hughes.
2 comments:
Patchset:
I think this warrants an entry in the release notes too, since it's a user-visible change.
File libflashrom.c:
Patch Set #3, Line 71: msg_gerr("%s deprecated, use flashrom_set_progress_callback_v2 instead\n", __func__);
This message will probably be shown to users more often than developers (who should see the warning at build-time), so I think it should try to be a little more helpful.
Perhaps: `"__func__: this function is deprecated and no progress will be reported (for developers: call __func___v2 instead)"`
I also think this shouldn't be logged at error level, because that seems likely to confuse people. Flashrom still works in this case, so it should be a warning.
To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.