Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
2 comments:
File dummyflasher.c:
Patch Set #16, Line 339: data->emu_status[0] &= ro_bits;
WIP was RO before, old code is: […]
And what does that tell us about the state of WIP after that line?
AFAICT, it was always cleared here. Does it matter? I guess no, but
I had to investigate (check all accesses to `emu_status` basically).
It's just so much nicer to investigate such things for dedicated
commits :) I guess changing this single line, no matter how minor
it seems, makes about 50% of the review of this change (and it's
not a small change).
Patch Set #16, Line 347: other chips might differ
At least datasheet for W25Q128FV claims otherwise in its note on previous generations: […]
So we actually know already that chips with different behavior exist.
That's already more information than the comment provides :) If that
is the reason for the comment, please rephrase.
Anyway, what I meant is that there can always be chips that act
differently. That's the case for WRSR, but also for WRSR2, and
also, less likely, for read/write/erase commands.
To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.