Attention is currently required from: Daniel Campello.
Patch set 7:Code-Review +1
View Change
1 comment:
File cli_classic.c:
Patch Set #7, Line 152: (argv[optind][0] != '-' || argv[optind][1] == '\0')
this is still confusing to read, imo
can you add to the comment above on line 150:
... however, - is treated as stdin/stdout, so we still strdup in this case
To view, visit change 52383. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d
Gerrit-Change-Number: 52383
Gerrit-PatchSet: 7
Gerrit-Owner: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Comment-Date: Fri, 16 Apr 2021 15:08:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment